Skip to content

feat: Add lazy mode argument to pyroscope.ebpf#4824

Merged
korniltsev-grafanista merged 2 commits intografana:mainfrom
luweglarz:luweglarz/ebpf-ctlr-lazy-mode
Dec 2, 2025
Merged

feat: Add lazy mode argument to pyroscope.ebpf#4824
korniltsev-grafanista merged 2 commits intografana:mainfrom
luweglarz:luweglarz/ebpf-ctlr-lazy-mode

Conversation

@luweglarz
Copy link
Contributor

@luweglarz luweglarz commented Nov 12, 2025

PR Description

This pr is for #3952, the goal here is only to defer eBPF profiler startup until there are actual targets to profile, I haven't implemented any stop/start mechanism depending on weather or not there are still targets as it might not be necessary yet, this could be implemented maybe in a future PR.

Which issue(s) this PR fixes

This PR fix the unnecessary usage of resource when alloy is deployed as a daemonset and doesn't necessarily have targets to profile

Notes to the Reviewer

To avoid the update args logic to be redundant I moved it into one function

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@luweglarz luweglarz requested review from a team and clayton-cornell as code owners November 12, 2025 14:28
@CLAassistant
Copy link

CLAassistant commented Nov 12, 2025

CLA assistant check
All committers have signed the CLA.

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Nov 18, 2025
@luweglarz
Copy link
Contributor Author

Hi @clayton-cornell , resolved conflict on changelog

@korniltsev-grafanista korniltsev-grafanista enabled auto-merge (squash) December 2, 2025 08:49
@korniltsev-grafanista korniltsev-grafanista merged commit 2eb281c into grafana:main Dec 2, 2025
39 checks passed
dehaansa pushed a commit to madhub/alloy that referenced this pull request Dec 10, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

frozen-due-to-age type/docs Docs Squad label across all Grafana Labs repos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants